Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[luci/service] Enhance handling CircleConst as reshape's shape #14037

Merged
merged 2 commits into from
Sep 23, 2024
Merged

[luci/service] Enhance handling CircleConst as reshape's shape #14037

merged 2 commits into from
Sep 23, 2024

Conversation

jongwonyang
Copy link
Member

@jongwonyang jongwonyang commented Sep 19, 2024 •
edited
Loading

This commit improves handling CircleConst as the shape for the reshape operation.

  • Use known explicitly instead of static_cast which can cause overflow.

Draft: #13999, #14034
Related: #13927

ONE-DCO-1.0-Signed-off-by: Jongwon Yang [email protected]

@jongwonyang jongwonyang requested review from a team September 19, 2024 07:44
@jongwonyang jongwonyang added PR/ready for review It is ready to review. Please review it. SSAFY labels Sep 19, 2024
@jongwonyang jongwonyang marked this pull request as ready for review September 19, 2024 07:44
@jongwonyang
Copy link
Member Author

jongwonyang commented Sep 20, 2024 •
edited
Loading

FYI, following is the road map of supporting dynamic shape inference for the reshape operation.

zetwhite
zetwhite reviewed Sep 20, 2024
View reviewed changes
compiler/luci/service/src/Nodes/CircleReshape.test.cpp Outdated
TEST(ShapeRuleTest, reshape_by_input_const_static)
TEST(ShapeRuleTest, reshape_by_const_static)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for curiosity, Is there a reason for changing this test name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for future naming consistency :)
I thought it could be too verbose if I keep naming like the old one.

zetwhite
zetwhite previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark
Copy link
Contributor

Your commit message is too verbose and it's hard to catch the change.
The change itself seems not related to your commit message.
It would be better to split the changes.

@jongwonyang
Copy link
Member Author

Your commit message is too verbose and it's hard to catch the change. The change itself seems not related to your commit message. It would be better to split the changes.

I've cleaned up the commit message to show the change and make it easy to read.

  • Add comments for future change.
  • Use known explicitly instead of static_cast which can cause overflow.
  • Rename TC name for future naming convention.

If you think these 3 changes need to be split, please let me know :)

@seanshpark
Copy link
Contributor

If you think these 3 changes need to be split, please let me know :)

How are these changes related to each other? Are these have tight relation and cannot be separated?
Is the purpose single or have different purposes?

@seanshpark
Copy link
Contributor

I've cleaned up the commit message to show the change and make it easy to read.

You should update the commit. ae2e783 is your current commit.

@jongwonyang
Copy link
Member Author

How are these changes related to each other? Are these have tight relation and cannot be separated? Is the purpose single or have different purposes?

They have different purposes. So it would be better to split. Thanks for pointing out.

@jongwonyang
[luci/service] Enhance handling CircleConst as reshape's shape
54f7234 
This commit improves handling `CircleConst` as the `shape` for the reshape operation.

- Use `known` explicitly instead of `static_cast` which can cause overflow.

ONE-DCO-1.0-Signed-off-by: Jongwon Yang <[email protected]>
@jongwonyang
Copy link
Member Author

You should update the commit. ae2e783 is your current commit.

I have split the change and update the commit. Please let me know if you have any question :)

@jongwonyang @seanshpark
[luci/service] Simplify boolean condition
03cb691 
This commit simplifies boolean condition.

ONE-DCO-Signed-off-by: Jongwon Yang <[email protected]>

Co-authored-by: SaeHie Park <[email protected]>
seanshpark
seanshpark approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

zetwhite
zetwhite approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh
Copy link
Contributor

@nnfw-bot test nncc-debug nncc-release tizen-gbs

@seanshpark seanshpark merged commit df751f6 into Samsung:master Sep 23, 2024
10 checks passed
shs-park
shs-park reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jongwonyang jongwonyang deleted the reshape-const branch September 24, 2024 23:41
@jongwonyang jongwonyang mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs-park shs-park shs-park left review comments

@seanshpark seanshpark seanshpark approved these changes

@zetwhite zetwhite zetwhite approved these changes

Assignees
No one assigned
Labels
PR/ready for review It is ready to review. Please review it. SSAFY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jongwonyang @seanshpark @hseok-oh @zetwhite @shs-park