[NUI] Make Action id as internal static readonly

Since we share the same action id for each Play / Pause / etc, we don't need to consider overwrite the action id now. Signed-off-by: Eunki Hong <[email protected]>
Samsung · Jul 25, 2023 · edd6be6 · edd6be6
1 parent 10522fe
commit edd6be6
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 36 deletions.
diff --git a/src/Tizen.NUI/src/public/BaseComponents/AnimatedImageView.cs b/src/Tizen.NUI/src/public/BaseComponents/AnimatedImageView.cs
@@ -28,6 +28,10 @@ namespace Tizen.NUI.BaseComponents
     public partial class AnimatedImageView : ImageView
     {
         #region Internal
+        /// <summary>
+        /// Actions property value to Jump to the specified frame.
+        /// </summary>
+        internal static readonly int ActionJumpTo = Interop.AnimatedImageView.AnimatedImageVisualActionJumpToGet();
         #endregion Internal
 
         #region Private
@@ -50,9 +54,6 @@ public partial class AnimatedImageView : ImageView
         [EditorBrowsable(EditorBrowsableState.Never)]
         public AnimatedImageView() : base()
         {
-            ActionPlay = Interop.AnimatedImageView.AnimatedImageVisualActionPlayGet();
-            ActionPause = Interop.AnimatedImageView.AnimatedImageVisualActionPauseGet();
-            ActionStop = Interop.AnimatedImageView.AnimatedImageVisualActionStopGet();
         }
 
         /// <summary>
@@ -355,13 +356,6 @@ private int InternalCurrentFrame
                 return ret;
             }
         }
-
-        /// <summary>
-        /// Actions property value to Jump to the specified frame.
-        /// This property can be redefined by child class if it use different value.
-        /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        protected int ActionJumpTo { get; set; } = Interop.AnimatedImageView.AnimatedImageVisualActionJumpToGet();
         #endregion Property
 
         #region Method

diff --git a/src/Tizen.NUI/src/public/BaseComponents/ImageView.cs b/src/Tizen.NUI/src/public/BaseComponents/ImageView.cs
@@ -891,28 +891,22 @@ private bool InternalCropToMask
         /// <summary>
         /// Actions property value for Reload image.
         /// </summary>
-        private int ActionReload { get; set; } = Interop.ImageView.ImageVisualActionReloadGet();
+        internal static readonly int ActionReload = Interop.ImageView.ImageVisualActionReloadGet();
 
         /// <summary>
         /// Actions property value to Play animated images.
-        /// This property can be redefined by child class if it use different value.
         /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        protected int ActionPlay { get; set; } = Interop.AnimatedImageView.AnimatedImageVisualActionPlayGet();
+        internal static readonly int ActionPlay = Interop.AnimatedImageView.AnimatedImageVisualActionPlayGet();
 
         /// <summary>
         /// Actions property value to Pause animated images.
-        /// This property can be redefined by child class if it use different value.
         /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        protected int ActionPause { get; set; } = Interop.AnimatedImageView.AnimatedImageVisualActionPauseGet();
+        internal static readonly int ActionPause = Interop.AnimatedImageView.AnimatedImageVisualActionPauseGet();
 
         /// <summary>
         /// Actions property value to Stop animated images.
-        /// This property can be redefined by child class if it use different value.
         /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        protected int ActionStop { get; set; } = Interop.AnimatedImageView.AnimatedImageVisualActionStopGet();
+        internal static readonly int ActionStop = Interop.AnimatedImageView.AnimatedImageVisualActionStopGet();
 
         internal VisualFittingModeType ConvertFittingModetoVisualFittingMode(FittingModeType value)
         {

diff --git a/src/Tizen.NUI/src/public/BaseComponents/LottieAnimationView.cs b/src/Tizen.NUI/src/public/BaseComponents/LottieAnimationView.cs
@@ -49,10 +49,6 @@ public partial class LottieAnimationView : ImageView
         /// <since_tizen> 7 </since_tizen>
         public LottieAnimationView(float scale = 1.0f, bool shown = true) : base()
         {
-            ActionPlay = Interop.LottieAnimationView.AnimatedVectorImageVisualActionPlayGet();
-            ActionPause = Interop.LottieAnimationView.AnimatedVectorImageVisualActionPauseGet();
-            ActionStop = Interop.LottieAnimationView.AnimatedVectorImageVisualActionStopGet();
-
             NUILog.Debug($"< constructor GetId={GetId()} >");
             currentStates.url = "";
             currentStates.loopCount = 1;
@@ -442,18 +438,6 @@ private bool InternalRedrawInScalingDown
                 return currentStates.redrawInScalingDown;
             }
         }
-
-
-        /// <summary>
-        /// Actions property value to Jump to the specified frame.
-        /// This property can be redefined by child class if it use different value.
-        /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        protected int ActionJumpTo { get; set; } = Interop.LottieAnimationView.AnimatedVectorImageVisualActionJumpToGet();
-
-        // This is used for internal purpose. hidden API.
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        protected int ActionSetDynamicProperty { get; set; } = Interop.LottieAnimationView.AnimatedVectorImageVisualActionSetDynamicProperty();
         #endregion Property
 
 
@@ -916,6 +900,14 @@ public enum VectorProperty
 
 
         #region Internal
+        /// <summary>
+        /// Actions property value to Jump to the specified frame.
+        /// </summary>
+        internal static readonly int ActionJumpTo = Interop.LottieAnimationView.AnimatedVectorImageVisualActionJumpToGet();
+
+        // This is used for internal purpose.
+        internal static readonly int ActionSetDynamicProperty = Interop.LottieAnimationView.AnimatedVectorImageVisualActionSetDynamicProperty();
+
         internal class VisualEventSignalArgs : EventArgs
         {
             public int VisualIndex