[NUI][AT-SPI] Set focus in OnAccessibilityActivated() #5386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the behaviour of Components (derived from CustomView), and other controls, with that
of BaseComponents (and other controls with ViewAccessibilityMode.Default, backed by the C++
accessibility implementation), which set the keyboard focus on activation. Please note that in the
latter case, the implementation of View.OnAccessibilityActivated is unused, and the unrelated method
(albeit bearing the same name) Toolkit::Control::OnAccessibilityActivated is called:
bool Control::OnAccessibilityActivated()
{
if(Toolkit::KeyboardFocusManager::Get().SetCurrentFocusActor(Self()))
{
return OnKeyboardEnter();
}
return false;
}
So, in other words, this patch makes C# controls behave in a similar manner, i.e. set the keyboard
focus on accessibility activation.
aswigon
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
loleksak
approved these changes
Jul 11, 2023
Seoyeon2Kim
approved these changes
Jul 12, 2023
JoogabYun
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This aligns the behaviour of
Components(derived fromCustomView), and other controls, with that ofBaseComponents(and other controls withViewAccessibilityMode.Default, backed by the C++ accessibility implementation), which set the keyboard focus on activation. Please note that in the latter case, the implementation ofView.OnAccessibilityActivatedis unused, and the unrelated method (albeit bearing the same name)Control::OnAccessibilityActivatedis called:So, in other words, this patch makes C# controls behave in a similar manner, i.e. set the keyboard focus on accessibility activation.
API Changes