[NUI] Delete the used window in widget #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete the used window so that the window can be deleted normally when deleting the widget. this is for memory leak issue.
tscholb
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho and
everLEEst
as code owners
huiyueun
reviewed
Jul 17, 2023
| @@ -109,6 +141,11 @@ static void Main(string[] args) | |||
| WidgetView mWidgetView2; | |||
| int widgetWidth; | |||
| int widgetHeight; | |||
|
|
|||
| Timer mTimer; | |||
There was a problem hiding this comment.
기존에도 없었던게 이상하긴 한데
private 붙여주는게 더 좋지 않을까요.
hinohie
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the used window so that the window can be deleted normally when deleting the widget. this is for memory leak issue.
Description of Change
API Changes