[NUI] Add VisibilityChanged event to Layer #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaehyun0cho
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub and
everLEEst
as code owners
Internal API ChangedAdded: 5, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.EventHandler`1<Tizen.NUI.Layer/VisibilityChangedEventArgs> Tizen.NUI.Layer::VisibilityChanged
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer/VisibilityChangedEventArgs
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Layer/VisibilityChangedEventArgs::Visibility()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer Tizen.NUI.Layer/VisibilityChangedEventArgs::Layer()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Layer/VisibilityChangedEventArgs::.ctor()
|
hinohie
approved these changes
Jul 18, 2023
huiyueun
reviewed
Jul 18, 2023
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public class VisibilityChangedEventArgs : EventArgs | ||
| { | ||
| private Layer _layer; |
There was a problem hiding this comment.
NUI 네이밍 룰과 맞지 않는 사용인거 같아요 '_layer'
There was a problem hiding this comment.
Thank you for your comment!
NUI naming rule is applied.
jaehyun0cho
force-pushed
the
AddVisibilityChangedToLayer_API10
branch
from
dc74245
to
bde93f0
Compare
Internal API ChangedAdded: 5, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.EventHandler`1<Tizen.NUI.Layer/VisibilityChangedEventArgs> Tizen.NUI.Layer::VisibilityChanged
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer/VisibilityChangedEventArgs
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Layer/VisibilityChangedEventArgs::Visibility()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer Tizen.NUI.Layer/VisibilityChangedEventArgs::Layer()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Layer/VisibilityChangedEventArgs::.ctor()
|
To notice the visibility changes of Layer, VisibilityChanged event is added to Layer.
jaehyun0cho
force-pushed
the
AddVisibilityChangedToLayer_API10
branch
from
bde93f0
to
67610fc
Compare
Thank you for your comment! |
Internal API ChangedAdded: 5, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.EventHandler`1<Tizen.NUI.Layer/VisibilityChangedEventArgs> Tizen.NUI.Layer::VisibilityChanged
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer/VisibilityChangedEventArgs
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.Layer/VisibilityChangedEventArgs::Visibility()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Layer Tizen.NUI.Layer/VisibilityChangedEventArgs::Layer()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Layer/VisibilityChangedEventArgs::.ctor()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To notice the visibility changes of Layer, VisibilityChanged event is added to Layer.
Description of Change
API Changes