Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI.Scene3D] Support SceneView CornerRadius and Borderline Property applied #6382

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Sep 27, 2024

Let we support CornerRadius and Borderline feature to SceneView.

Note that those features are available only if UseFramebuffer = true;

Relative dali patch :

https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/318377
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/318385

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 6, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.ImageView::ApplyBorderline()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.ImageView::ApplyCornerRadius()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.View::ApplyBorderline()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.View::ApplyCornerRadius()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::ApplyCornerRadius()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Scene3D.SceneView::ApplyCornerRadius()

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 7, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.ImageView::ApplyBorderline()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.ImageView::ApplyCornerRadius()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.View::ApplyBorderline()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.View::ApplyCornerRadius()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.BaseComponents.WebView::ApplyCornerRadius()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Scene3D.SceneView::ApplyBorderline()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Scene3D.SceneView::ApplyCornerRadius()

@hinohie hinohie changed the title [NUI.Scene3D] Support SceneView CornerRadius Property applied [NUI.Scene3D] Support SceneView CornerRadius and Borderline Property applied Sep 30, 2024
Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Contributor

@tscholb tscholb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hinohie hinohie merged commit c0619f5 into Samsung:DevelNUI Oct 10, 2024
3 checks passed
@hinohie hinohie deleted the scene_view_corner_radius branch October 10, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants