[NUI] Rebase from DevelNUI to master #6415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix the crash issue : A callback was made on a garbage collected delegate of type 'Tizen.NUI!Tizen.NUI.WebContext+WebContextHttpRequestInterceptedProxyCallback::Invoke'
1) DF240922-00003 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=43585 false alarm At line 755, a null check has been already performed ; the item "e.Proposed" which was pointed out as an problem cannot become null. As such, this issue does not require correction as it is a false alarm. 2) DF240907-00723 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=176282 fixed 3) DF240907-00695 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=176248 fixed 4) DF240906-00277 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=174470 fixed 5) DF240905-01180 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=43601 At line 1014, a null check has been already performed; if it is null, an exception will be thrown. Therefore, at line 1018, the item which was pointed out as an problem cannot become null. As such, this issue does not require correction as it is a false alarm. 6) DF240821-00053 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=163282 fixed 7) DF240716-01912 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=163084 already fixed in the previous patch
Since dali_2.3.41, MixColor property animate by Vector4 type. But NUI animation property helper doesn't apply those changeness. To match the previous behavior, let we make BackgroundColor and BoxShadow.Color animate by Color class well. Signed-off-by: jmm <[email protected]>
Signed-off-by: Eunki, Hong <[email protected]>
dongsug-song
requested review from
hyunjushin,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
JoogabYun
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[NUI] Rebase from DevelNUI to master
API Changes
nothing