Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created CL is not cleaned on failed submit #388

Closed
k-dovgan opened this issue Apr 3, 2020 · 4 comments · Fixed by #409
Closed

Created CL is not cleaned on failed submit #388

k-dovgan opened this issue Apr 3, 2020 · 4 comments · Fixed by #409
Assignees
Labels
bug Something isn't working component: submitter

Comments

@k-dovgan
Copy link
Contributor

k-dovgan commented Apr 3, 2020

Description

If submit fails, reconciled changes are stored in newly created CL; this behaviour interferes with automation.

Steps to reproduce

  1. Configure special p4 submit requirements, such as mandatory review or explicit CL description.
  2. Use Universum to submit a CL not meeting those requirements.

Expected result

Exception logged; local files left unchanged; created CL deleted; changes in VCS reverted

Actual result

Exception logged; local files left unchanged; created CL left hanging with all changes added for VCS

@k-dovgan k-dovgan added bug Something isn't working component: submitter labels Apr 3, 2020
@k-dovgan k-dovgan self-assigned this Apr 3, 2020
@k-dovgan
Copy link
Contributor Author

k-dovgan commented Apr 9, 2020

Here's the list of possible scenarios, leading to this error:

  • requirements of special CL description format not fulfilled
  • requirements of mandatory code review not fulfilled
  • no 'write' rights for the target
  • submitted files have been changed since CL creation (e.g. by another user)
  • server-side problems (e.g. server application crashed)
  • network problems (e.g. server temporarily inaccessible)

@i-keliukh
Copy link
Contributor

Please create separate issue for tracking the implementation of test for handling of submit failure and copy the description of the scenarios there.

@k-dovgan
Copy link
Contributor Author

See #396

@k-dovgan
Copy link
Contributor Author

Fixed by #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: submitter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants