Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(test): submit to protected branches #398

Merged
merged 11 commits into from
Apr 21, 2020
Merged

add(test): submit to protected branches #398

merged 11 commits into from
Apr 21, 2020

Conversation

k-dovgan
Copy link
Contributor

@k-dovgan k-dovgan commented Apr 14, 2020 •
edited
Loading

Check 3&4 from #396

@k-dovgan k-dovgan changed the title add(test): protect branch from changes and fail to submit fix(submit): rollback any changes in p4 if submit fails Apr 15, 2020
@k-dovgan k-dovgan changed the title fix(submit): rollback any changes in p4 if submit fails add(test): submit to write- and open-protected branches in p4 Apr 15, 2020
@k-dovgan k-dovgan changed the title add(test): submit to write- and open-protected branches in p4 add(test): submit to write- and open-protected branches Apr 15, 2020
@k-dovgan k-dovgan requested a review from i-keliukh April 15, 2020 14:20
@k-dovgan k-dovgan changed the title add(test): submit to write- and open-protected branches add(test): submit to protected branches Apr 17, 2020
i-keliukh
i-keliukh reviewed Apr 17, 2020
View reviewed changes
tests/perforce_utils.py Show resolved Hide resolved
tests/perforce_utils.py Outdated Show resolved Hide resolved
tests/perforce_utils.py Outdated Show resolved Hide resolved
tests/test_p4_submit.py Outdated Show resolved Hide resolved
tests/test_p4_submit.py Outdated Show resolved Hide resolved
tests/test_p4_submit.py Outdated Show resolved Hide resolved
tests/test_p4_submit.py Outdated Show resolved Hide resolved
@k-dovgan k-dovgan merged commit 017fae9 into master Apr 21, 2020
@k-dovgan k-dovgan deleted the 388-cleanup-failed-submit branch April 21, 2020 07:01
@k-dovgan k-dovgan mentioned this pull request Apr 21, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-keliukh i-keliukh i-keliukh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-dovgan @i-keliukh