Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(configs): remove pip progress bars (requires pip>=10) #468

Merged
merged 1 commit into from
Jul 17, 2020
Merged

fix(configs): remove pip progress bars (requires pip>=10) #468

merged 1 commit into from
Jul 17, 2020

Conversation

k-dovgan
Copy link
Contributor

@k-dovgan k-dovgan commented Jul 9, 2020

Done in scope of #361; though detecting and processing by Universum interactive progress bars doesn't actually seem possible at the moment

@k-dovgan k-dovgan requested a review from i-keliukh July 9, 2020 16:08
i-keliukh
i-keliukh reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@i-keliukh i-keliukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about pip command line used in tests?

@k-dovgan
Copy link
Contributor Author

What about pip command line used in tests?

  1. Pip modules are installed in docker containers once before all tests
  2. The output of these commands is hidden unless something went wrong
  3. Actually, we do not update Pip to latest version in docker container, it has pip 9.0.1; so the '--progress-bar off' is not even applicable. And taking in mind it is not showed anyway, I don't think it's worth adding?

@i-keliukh i-keliukh merged commit 09ab9e5 into master Jul 17, 2020
@i-keliukh i-keliukh deleted the 361-remove-progress-bars branch July 17, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-keliukh i-keliukh i-keliukh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-dovgan @i-keliukh