update(KeyBinds): Create shortcut to open uplink when it is minimized #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Don't merge yet
UI Automated Test Results Summary for MacOS/Windows500 tests 448 ✅ 2h 32m 45s ⏱️ Results for commit 9bab3d3. ♻️ This comment has been updated with latest results. |
|
UI Automated Tests execution is complete! You can find the test results report here |
|
@lgmarchi Hey bro, so on Mac the maximize is working great but on windows I wasnt able to get it to work 20240122-1741-14.3311313.mp4 |
…hen-it-is-minimize' into create-shortcut-to-open-uplink-when-it-is-minimize
lgmarchi
added
Ready for testing
github-actions
bot
added
the
Failed Automated Test
|
Lucas is taking a look into an issue I DM'd him about, if you are clicked into another app like Chrome and then you use the shortcut to maximize Uplink you will see Uplink flash open for a minute but it will get hidden behind Chrome Screen_Recording_2024-01-23_at_11.46.03_AM.mov |
phillsatellite
added
Changes requested
github-actions
bot
removed
the
Failed Automated Test
phillsatellite
removed
the
Changes requested
phillsatellite
approved these changes
Jan 23, 2024
phillsatellite
added
the
Waiting for CI
luisecm
removed
the
Waiting for CI
github-actions
bot
added
linter failing
github-actions
bot
removed
the
linter failing
phillsatellite
added
QA Tested
InfamousVague
approved these changes
Jan 24, 2024
InfamousVague
approved these changes
Jan 24, 2024
…hen-it-is-minimize' into create-shortcut-to-open-uplink-when-it-is-minimize
lgmarchi
deleted the
create-shortcut-to-open-uplink-when-it-is-minimize
branch
github-actions
bot
removed
QA Tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
1. Create shortcut to open uplink when it is minimized
Screen.Recording.2024-01-19.at.10.19.39.mov
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤