-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(groups): Fix search crashes #1736
Conversation
UI Automated Test Results Summary for MacOS/Windows490 tests 438 ✅ 2h 39m 34s ⏱️ Results for commit 9ec1792. ♻️ This comment has been updated with latest results. |
UI Automated Tests execution is complete! You can find the test results report here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it crashes using korean chars
안녕하세요
STR:
- go to chat
- create group with name 안녕하세요
- search for it
- crash
crash log from macOS
https://gist.github.com/stavares843/df879ebc26b2c1995008f38a42c23356
crash log from uplink
19-01-2024_19-27-35.log
video
Gravacao.do.ecra.2024-01-19.as.19.37.27.mov
i also noticed that searching using greek or cyrillic does not perform the search STR:
unsure if works on dev because trying the same on dev crashes Cyrillic Script: Greek Script: macOS, m1 |
i am unable to reproduce it. are you sure its on this branch? |
was a case sensitiv issue. fixed now |
What this PR does 📖
Which issue(s) this PR fixes 🔨