Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(Attachments): Improve attachments code, remove duplicates #1831

Merged
merged 6 commits into from
Feb 8, 2024
Merged

update(Attachments): Improve attachments code, remove duplicates #1831

merged 6 commits into from
Feb 8, 2024

Conversation

lgmarchi
Copy link
Contributor

@lgmarchi lgmarchi commented Feb 7, 2024 •
edited by dariusc93
Loading

What this PR does 📖

  1. Made improvement to attachment code and remove duplication.

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

  • This PR should be tested on all ways possible to attach and send files, from Storage and Local Disk.

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Feb 7, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Feb 7, 2024
@github-actions github-actions bot added linter failing Cargo Workflow (linter) failed on this PR and removed linter failing Cargo Workflow (linter) failed on this PR labels Feb 7, 2024
dariusc93
dariusc93 reviewed Feb 7, 2024
View reviewed changes
ui/src/layouts/chats/mod.rs Outdated Show resolved Hide resolved
ui/src/layouts/chats/mod.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

502 tests   450 ✅  2h 17m 7s ⏱️
 42 suites   52 💤
  3 files      0 ❌

Results for commit 40ce2e9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Feb 7, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Feb 8, 2024
@stavares843 stavares843 added checking stuff and removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Feb 8, 2024
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed checking stuff labels Feb 8, 2024
@stavares843 stavares843 merged commit 81b5618 into dev Feb 8, 2024
5 of 7 checks passed
@stavares843 stavares843 deleted the improve-attachments-code branch February 8, 2024 16:23
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Waiting for CI Waiting for at least one CI job to complete before merging labels Feb 8, 2024
@stavares843 stavares843 removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@stavares843 stavares843 stavares843 approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees

@lgmarchi lgmarchi

Labels
None yet
Projects
Uplink
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task(review): address review
4 participants
@lgmarchi @dariusc93 @stavares843 @phillsatellite