task(chat): Update what should be skipped in state.json

[Flemmli97]

What this PR does 📖

• Do not (de)serialize chats.
  • Conversations are already fetched from warp on load. This will just make it not save those chats.
  • Chats in sidebar are simply resolved with the uuids
  • Not saving the chats should prevent problems with loading when the internal structure changes.

Which issue(s) this PR fixes 🔨

• Resolve task(chats): load the conversations on initialization and not do based on what is there in the state #1936

Additional comments 🎤

We should probably move sidebar chats + favorites to warp.

[github-actions]

⚠️ The title of this PR is invalid.
Please make the title match the regex (?:add|update|task|chore|feat|fix|refactor)\([a-z-A-Z]+\):\s.+.
e.g.) add(cli): enable --verbose flag, fix(api): avoid unexpected error in handler

[github-actions]

UI Automated Test Results Summary for MacOS/Windows

509 tests   449 ✅  2h 58m 8s ⏱️
 45 suites   60 💤
  3 files      0 ❌

Results for commit d36d151.

♻️ This comment has been updated with latest results.

[github-actions]

UI Automated Tests execution is complete! You can find the test results report here

[phillsatellite]

So I deleted my state.json and reloaded the app and conversations were missing

Screen.Recording.2024-04-08.at.1.56.05.PM.mov

[Flemmli97]

yes because the sidebars are still saved in state.json. the chats are still there. though you would need to click on the friends page to chat first.
ideally in the future it should be moved to warp but for now thats not the case

[dariusc93]

yes because the sidebars are still saved in state.json. the chats are still there. though you would need to click on the friends page to chat first. ideally in the future it should be moved to warp but for now thats not the case

Uplink should be loading Conversation into state during initializing, including anything into the sidebar and not depend on data representing conversations in state.json. This likely could be done with

Uplink/common/src/warp_runner/manager/commands/raygun_commands.rs

Line 442 in 8142b4f

async fn init_warp(

.

[Flemmli97]

yes because the sidebars are still saved in state.json. the chats are still there. though you would need to click on the friends page to chat first. ideally in the future it should be moved to warp but for now thats not the case

Uplink should be loading Conversation into state during initializing, including anything into the sidebar and not depend on data representing conversations in state.json. This likely could be done with

Uplink/common/src/warp_runner/manager/commands/raygun_commands.rs

Line 442 in 8142b4f

async fn init_warp(

.

this is already whats being done.
state now only has data whether the chat should be displayed in the sidebar or not (and favorites). which is just a uuid reference

[dariusc93]

this is already whats being done. state now only has data whether the chat should be displayed in the sidebar or not (and favorites). which is just a uuid reference

If thats the case, shouldnt the conversations be loaded up into the sidebar after the state.json is removed or overridden? The favorites part can be dealt with later on warp side (already have a branch for marking a conversation as favorite).

[Flemmli97]

i guess we can make it so that if the state.json is completly missing it adds all conversations to the sidebar?

[dariusc93]

i guess we can make it so that if the state.json is completly missing it adds all conversations to the sidebar?

That, or probably compare the state to what is available on warp to see if a conversation was deleted or is missing and just remove that invalid entry.

[Flemmli97]

the thing is you can hide a chat on uplink and it will not be in the sidebar anymore. but the chat is still there

[dariusc93]

the thing is you can hide a chat on uplink and it will not be in the sidebar anymore. but the chat is still there

I think that will be fine for now as we can treat this as a client-to-client bases for the time being

[Flemmli97]

marked as change request cause want to make it so if the state is e.g. new all chats will be loaded into the sidebar

[phillsatellite]

Sara and I retested again and still had chats missing when we would delete are state.json but something I noticed is when you login the button on the landing page will say Start a chat and then quickly change to Go to Friends so it does seem like Warp/Uplink is realizing that there are chats to load its just they never appear

Screen.Recording.2024-04-12.at.11.15.41.AM.mov

[Flemmli97]

changed that field to be serialized. there is prob a better way to do it but that would require some design changes since state gets written to multiple times before the app is completely initialized. (e.g. during login)