fix(calling): Request mic (and camera) #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Don't merge yet
dariusc93
approved these changes
Apr 11, 2024
UI Automated Test Results Summary for MacOS/Windows430 tests 369 ✅ 2h 45m 32s ⏱️ For more details on these failures and errors, see this check. Results for commit e291500. |
|
UI Automated Tests execution is complete! You can find the test results report here |
stavares843
approved these changes
Apr 11, 2024
stavares843
added
QA Tested
phillsatellite
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Which issue(s) this PR fixes 🔨
Additional comments 🎤
The prod build works on linux. The issue also mentions windows but i am unsure about that since idk if you need to request access to the mic or not there.
(though it can also be that the testing done in the issue was via a windows <-> mac communication which made it seem like so)