Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): fix typo on env variable for cert #1987

Merged
merged 1 commit into from
May 6, 2024
Merged

chore(build): fix typo on env variable for cert #1987

merged 1 commit into from
May 6, 2024

Conversation

luisecm
Copy link
Contributor

@luisecm luisecm commented May 6, 2024

What this PR does 📖

  • It looks like one more "" is being passed in environment variable for SM_CLIENT_CERT_FILE and this is making the signtool process to fail on uplink copy repo when running build windows action
    image

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels May 6, 2024
@stavares843 stavares843 merged commit 6a5b5c7 into dev May 6, 2024
3 checks passed
@stavares843 stavares843 deleted the luis/build-fix branch May 6, 2024 22:45
@github-actions github-actions bot removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

Assignees

@luisecm luisecm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisecm @stavares843