Skip to content
This repository has been archived by the owner on Sep 13, 2021. It is now read-only.

Added 'since' and 'until' selection modes #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theonelucas
Copy link

No description provided.

@theonelucas theonelucas mentioned this pull request May 22, 2019
@SaturnTeam
Copy link
Owner

Please don't change the styles just because you don't like them. I don't like them too, but it's better to keep original material code styles, to reduce my time on upgrading library. Just don't original strings it is not needed.
Why do you need number type? I see a lot of strings like D | number | null;

@theonelucas theonelucas force-pushed the selection-modes branch 2 times, most recently from 2374002 to e582dd7 Compare May 28, 2019 12:03
@SaturnTeam
Copy link
Owner

@theonelucas Look at diff. There are a lot of lines where you replaced == to === and other style-only changes. I asked you to not do that.

@theonelucas theonelucas force-pushed the selection-modes branch 2 times, most recently from 13f85ca to 3a75a21 Compare June 10, 2019 09:40
@thomas-parrish
Copy link

Why hasn't this been accepted yet?

@SaturnTeam
Copy link
Owner

@theonelucas because the author ignores my remarks (for example file.txt is still inside pr). And I have doubts about hard-coded selectors.

@GeorgKa
Copy link

GeorgKa commented Sep 18, 2019

That would be a great feature, is there any news?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants