Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolves #359] Implements use previous paramater feature #914

Closed

Conversation

RobReus
Copy link

@RobReus RobReus commented Jul 1, 2020

Resolves #359

This new feature will make it possible to create and maintain stacks using Sceptre while also having the possibility to modify parameters outside of Sceptre, without Sceptre then overwriting/reverting these changes.

An example use-case: create and maintain your containerized environment using Sceptre, but after the initial deploy, maintain the Docker image tag using a CICD pipeline. When configuring the image tag parameter correctly, it will be given an initial value upon creation, but updates will not overwrite the value.

It is as simple as this:

parameters:
  Param:
    initial_value: "foobar"
    use_previous_value: true

It is fully backwards compatible and will not break existing functionality.

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (make test) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes flake8 (make lint) checks.
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

@ngfgrant
Copy link
Contributor

ngfgrant commented Jul 1, 2020

First visual pass - this looks great thanks. I’ll try get hands on with it soon.

@RobReus
Copy link
Author

RobReus commented Aug 3, 2020

@ngfgrant any update on this? Anything that could be done by me or others to speed up the review and release process?

Happy to help where I can.

@alex-harvey-z3q
Copy link
Contributor

@RobReus Are you still using Sceptre and still interested in helping to get this feature merged?

@RobReus
Copy link
Author

RobReus commented Jun 10, 2024

@RobReus Are you still using Sceptre and still interested in helping to get this feature merged?

Unfortunately I have since moved away from using Sceptre and no longer have the time to work on this. Thanks for checking in though!

@alex-harvey-z3q
Copy link
Contributor

@RobReus All good. You seem to have done most of the hard work. I'll see if I can adopt the PR!

@alex-harvey-z3q
Copy link
Contributor

Closing in favour of #1476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't override existing parameters
3 participants