-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto language + add navigator preferences #349
Conversation
82338e3
to
5e48450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Remove :
Removing the switch would be fine for standalone application. Up to you - if there remove ends in a benefit then just remove it. Otherwise fine from ourside
Don't remove :
This language switch should stay there because the user might want to switch manually the language preference - especially he works for a company with fixed language covernance which is represented in the IT system. For example, if we have a business system installation, it might depend on the system administrator's settings. For instance, we have German installations, but users might prefer to have another language.
Is this as well fine for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested good work.
5fc5974
to
b993678
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from these two minor issues, looks good to me, thanks for refactoring!
Signed-off-by: Louis Greiner <[email protected]>
8b7e664
to
a2e1541
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Signed-off-by: Louis Greiner <[email protected]>
41b735c
to
2097387
Compare
Description
@Input (setter)
(instandalone
mode especially)Issues
"locale" -> "language"
since a locale is something like"fr-FR"
and a language"fr"
, and we use"fr"
as value for the language ; but i can revert these changes and bring back the"locale"
@Input (getter)
to uniformize the code, because the getter is called at any change (including mouse move), then involving too many actions and crash the applicationChecklist
documentation/