Merge pull request #1145 from SciML/ChrisRackauckas-patch-2

Don't allow picking GaussAdjoint with TrackerVJP in default alg
SciML · Nov 9, 2024 · 59c8068 · 59c8068
2 parents 6d81222 + 8ec9647
commit 59c8068
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/concrete_solve.jl b/src/concrete_solve.jl
@@ -184,7 +184,7 @@ function automatic_sensealg_choice(
                 # QuadratureAdjoint skips all p calculations until the end
                 # So it's the fastest when there are no parameters
                 QuadratureAdjoint(autodiff = false, autojacvec = vjp)
-            elseif prob isa ODEProblem
+            elseif prob isa ODEProblem && !(vjp isa TrackerVJP)
                 GaussAdjoint(autodiff = false, autojacvec = vjp)
             else
                 InterpolatingAdjoint(autodiff = false, autojacvec = vjp)
@@ -194,7 +194,7 @@ function automatic_sensealg_choice(
                 # QuadratureAdjoint skips all p calculations until the end
                 # So it's the fastest when there are no parameters
                 QuadratureAdjoint(autojacvec = vjp)
-            elseif prob isa ODEProblem
+            elseif prob isa ODEProblem && !(vjp isa TrackerVJP)
                 GaussAdjoint(autojacvec = vjp)
             else
                 InterpolatingAdjoint(autojacvec = vjp)
@@ -209,15 +209,15 @@ function automatic_sensealg_choice(
             # If reverse-mode isn't working, just fallback to numerical vjps
             if p === nothing || p === SciMLBase.NullParameters()
                 QuadratureAdjoint(autodiff = false, autojacvec = vjp)
-            elseif prob isa ODEProblem
+            elseif prob isa ODEProblem && !(vjp isa TrackerVJP)
                 GaussAdjoint(autodiff = false, autojacvec = vjp)
             else
                 InterpolatingAdjoint(autodiff = false, autojacvec = vjp)
             end
         else
             if p === nothing || p === SciMLBase.NullParameters()
                 QuadratureAdjoint(autojacvec = vjp)
-            elseif prob isa ODEProblem
+            elseif prob isa ODEProblem && !(vjp isa TrackerVJP)
                 GaussAdjoint(autojacvec = vjp)
             else
                 InterpolatingAdjoint(autojacvec = vjp)