Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reinstate repack #1147

Merged
merged 2 commits into from
Nov 18, 2024
Merged

chore: reinstate repack #1147

merged 2 commits into from
Nov 18, 2024

Conversation

DhairyaLGandhi
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here. solves #1146

@DhairyaLGandhi
Copy link
Member Author

@AayushSabharwal could the restructure adjoint have introduced the failures in Core 5?

@AayushSabharwal
Copy link
Member

The logs it's showing me are truncated to after line 5471, I can't see the error

@DhairyaLGandhi
Copy link
Member Author

@AayushSabharwal
Copy link
Member

I don't think it's ArrayInterface.restructure. I added an error() in the adjoint, and it still gives the same result as CI.

@DhairyaLGandhi
Copy link
Member Author

Both the reverse mode methods produce identical gradients, and has 6-7 digits off accuracy with the FD comparison.

@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review November 18, 2024 18:46
@ChrisRackauckas ChrisRackauckas merged commit aef3a2c into master Nov 18, 2024
13 of 17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the dg/nnrev3 branch November 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants