Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow picking GaussAdjoint with TrackerVJP in default alg #1145

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Don't allow picking GaussAdjoint with TrackerVJP in default alg #1145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/concrete_solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ function automatic_sensealg_choice(
# QuadratureAdjoint skips all p calculations until the end
# So it's the fastest when there are no parameters
QuadratureAdjoint(autodiff = false, autojacvec = vjp)
elseif prob isa ODEProblem
elseif prob isa ODEProblem && !(vjp isa TrackerVJP)
GaussAdjoint(autodiff = false, autojacvec = vjp)
else
InterpolatingAdjoint(autodiff = false, autojacvec = vjp)
Expand All @@ -194,7 +194,7 @@ function automatic_sensealg_choice(
# QuadratureAdjoint skips all p calculations until the end
# So it's the fastest when there are no parameters
QuadratureAdjoint(autojacvec = vjp)
elseif prob isa ODEProblem
elseif prob isa ODEProblem && !(vjp isa TrackerVJP)
GaussAdjoint(autojacvec = vjp)
else
InterpolatingAdjoint(autojacvec = vjp)
Expand All @@ -209,15 +209,15 @@ function automatic_sensealg_choice(
# If reverse-mode isn't working, just fallback to numerical vjps
if p === nothing || p === SciMLBase.NullParameters()
QuadratureAdjoint(autodiff = false, autojacvec = vjp)
elseif prob isa ODEProblem
elseif prob isa ODEProblem && !(vjp isa TrackerVJP)
GaussAdjoint(autodiff = false, autojacvec = vjp)
else
InterpolatingAdjoint(autodiff = false, autojacvec = vjp)
end
else
if p === nothing || p === SciMLBase.NullParameters()
QuadratureAdjoint(autojacvec = vjp)
elseif prob isa ODEProblem
elseif prob isa ODEProblem && !(vjp isa TrackerVJP)
GaussAdjoint(autojacvec = vjp)
else
InterpolatingAdjoint(autojacvec = vjp)
Expand Down
Loading