MNT: Switch to (lon, lat) for all argument and return ordering #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are more usages of (lon, lat) currently and only a few private versions of (lat, lon) so it is easy enough to switch everything over to (lon, lat) for consistency.
QuLogic
reviewed
Oct 11, 2024
| @@ -36,7 +36,7 @@ def test_osni(self, approx): | |||
| ll = ccrs.Geodetic() | |||
|
|
|||
| # results obtained by nearby.org.uk. | |||
| lat, lon = np.array([54.5622169298669, -5.54159863617957], | |||
| lon, lat = np.array([-5.54159863617957, 54.5622169298669], | |||
There was a problem hiding this comment.
Why is this even put through np.array in the first place if it's split immediately?
There was a problem hiding this comment.
🤷 I was wondering the same thing, but really didn't want to go refactoring more than this PR title suggests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more usages of (lon, lat) currently and only a few private versions of (lat, lon) so it is easy enough to switch everything over to (lon, lat) for consistency. This matches what we are expecting from transform_point(x, y) as well.