The Everything Update (UI Overhaul + Bug Fixes) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Umbranoxio
reviewed
Nov 4, 2024
ScoreSaber/Core/ReplaySystem/Playback/ReplayTimeSyncController.cs
Outdated
Show resolved
Hide resolved
|
This spacing is rather odd, either the modal should be smaller or we need more data to fill it out |
|
Personally would prefer if this was left aligned again |
|
Maybe add some outer padding to this to add a close window button? If you want to get fancy a minimize button too where the difference is it'll put a tiny button in the bottom left of the screen to bring the window back up. Or; simply a hint letting the user know about the "I" hotkey
|
|
Might also be a good idea to remove the Map info button & Map webpage button and present the modal when clicking the leaderboard header, the map webpage button should be in this modal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have probably forgotten something...