Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction to FINOS CCC #242

Merged
merged 33 commits into from
Oct 15, 2024
Merged

Conversation

smendis-scottlogic
Copy link
Contributor

@smendis-scottlogic smendis-scottlogic commented Sep 23, 2024

Please add a direct link to your post here:

https://smendis-scottlogic.github.io/blog/2024/09/23/intro-finos-ccc.html

Have you (please tick each box to show completion):

  • Added your blog post to a single category?
  • Added a brief summary for your post? Summaries should be roughly two sentences in length and give potential readers a good idea of the contents of your post.
  • Checked that the build passes?
  • Checked your spelling (you can use npm install followed by npx mdspell "**/{FILE_NAME}.md" --en-gb -a -n -x -t if that's your thing)
  • Ensured that your author profile contains a profile image, and a brief description of yourself? (make it more interesting than just your job title!)
  • Optimised any images in your post? They should be less than 100KBytes as a general guide.

Posts are reviewed / approved by your Regional Tech Lead.

Copy link
Contributor

@dogle-scottlogic dogle-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a few suggestions. Might be worth putting an image or two in to break it up as well - even if it's just a stock pic 😄

_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
@smendis-scottlogic
Copy link
Contributor Author

Looks good - a few suggestions. Might be worth putting an image or two in to break it up as well - even if it's just a stock pic 😄

Thank you so much for your comments. Really appreciate it. Will go through and fix them.

@smendis-scottlogic smendis-scottlogic changed the title Introduction to FINOS CCC Draft: Introduction to FINOS CCC Sep 24, 2024
@smendis-scottlogic smendis-scottlogic marked this pull request as draft September 24, 2024 07:44
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
@smendis-scottlogic smendis-scottlogic marked this pull request as ready for review September 25, 2024 14:35
@smendis-scottlogic smendis-scottlogic changed the title Draft: Introduction to FINOS CCC Introduction to FINOS CCC Sep 25, 2024
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
Copy link

@cfisher-scottlogic cfisher-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incredibly comprehensive and well-written blog, and I felt that was worth calling out. Kudos!

I've left a comment on the ordering of the opening sections. It's a bit wordy, but only in an effort to be helpful. Feel free to challenge my perspective. Crucially, this specific suggestion doesn't detract from the overall impressiveness of the blog. 😊

_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
Copy link

@rgriffiths-scottlogic rgriffiths-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great piece of work, Sonali!
All of my comments are truly minor - just adding some polish!
Once you've considered them, I'll read it as an actual blog (having just read source code version now) before you commit - just in case there are some source -> blog formatting weirdnesses that occur.

_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Show resolved Hide resolved
Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive body of work, and given it's a blog post about a tech standard, surprisingly readable 😆

A few comments on link texts, for the benefits of SEO, plus a handful of typos. You might want to reach for a second opinion though...

_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
_posts/2024-09-23-intro-finos-ccc.md Outdated Show resolved Hide resolved
@smendis-scottlogic
Copy link
Contributor Author

Impressive body of work, and given it's a blog post about a tech standard, surprisingly readable 😆

A few comments on link texts, for the benefits of SEO, plus a handful of typos. You might want to reach for a second opinion though...

Will fix these. Thanks for taking a look.

Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I think everything else has been addressed.

@chriswilty chriswilty merged commit 496a1a4 into ScottLogic:gh-pages Oct 15, 2024
1 check passed
jwarren-scottlogic pushed a commit to jwarren-scottlogic/blog that referenced this pull request Oct 21, 2024
Introduction to FINOS Common Cloud Controls

---------

Co-authored-by: sshiells-scottlogic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants