-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction to FINOS CCC #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - a few suggestions. Might be worth putting an image or two in to break it up as well - even if it's just a stock pic 😄
Thank you so much for your comments. Really appreciate it. Will go through and fix them. |
Co-authored-by: sshiells-scottlogic <[email protected]>
Co-authored-by: sshiells-scottlogic <[email protected]>
Co-authored-by: sshiells-scottlogic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an incredibly comprehensive and well-written blog, and I felt that was worth calling out. Kudos!
I've left a comment on the ordering of the opening sections. It's a bit wordy, but only in an effort to be helpful. Feel free to challenge my perspective. Crucially, this specific suggestion doesn't detract from the overall impressiveness of the blog. 😊
Co-authored-by: sshiells-scottlogic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great piece of work, Sonali!
All of my comments are truly minor - just adding some polish!
Once you've considered them, I'll read it as an actual blog (having just read source code version now) before you commit - just in case there are some source -> blog formatting weirdnesses that occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive body of work, and given it's a blog post about a tech standard, surprisingly readable 😆
A few comments on link texts, for the benefits of SEO, plus a handful of typos. You might want to reach for a second opinion though...
Will fix these. Thanks for taking a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I think everything else has been addressed.
Introduction to FINOS Common Cloud Controls --------- Co-authored-by: sshiells-scottlogic <[email protected]>
Please add a direct link to your post here:
https://smendis-scottlogic.github.io/blog/2024/09/23/intro-finos-ccc.html
Have you (please tick each box to show completion):
npm install
followed bynpx mdspell "**/{FILE_NAME}.md" --en-gb -a -n -x -t
if that's your thing)Posts are reviewed / approved by your Regional Tech Lead.