828 streamline network call for toggle defence #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswilty
reviewed
Mar 28, 2024
| const { chatInfoMessage } = | ||
| (await response.json()) as ChatInfoMessageResponse; | ||
|
|
||
| return makeChatMessageFromDTO(chatInfoMessage); |
There was a problem hiding this comment.
The lovely thing about returning a ChatMessage from all these service functions is that it'd be really easy to return an "error" chat message to go into the chat panel, instead of null to be ignored. If only we had time....
pmarsh-scottlogic
deleted the
828-streamline-network-call-for-toggle-defence
branch
chriswilty
pushed a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we would activate/deactivate in the backend. If that was sucessful, then the frontend would send a further request to add an info message to the history. Now the backend generates this info message and forwards it to the frontend.
Concerns
Checklist
Have you done the following?