Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display banner with cloud connection result #52

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

foodprocessor
Copy link
Collaborator

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

@foodprocessor
Copy link
Collaborator Author

We could potentially include a specific error message in the banner when the connection fails.
It's not too much more work. Y'all can decide if that should be in this PR or on the backlog.

src/plugin/settings/engine.cpp Outdated Show resolved Hide resolved
@foodprocessor foodprocessor merged commit 77bbe56 into main Aug 27, 2024
12 checks passed
@foodprocessor foodprocessor deleted the mount-feedback branch August 27, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants