Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): adserver is very noisy for feedback requests, possibly affecting performance #5351

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

majolo
Copy link
Contributor

@majolo majolo commented Feb 20, 2024

This currently produces the below for every single Feedback requests(and there can be 10s of thousands) - this is not helping with performance or readability.

│ INFO:root:PROCESSING Feedback Event.                                                                                                                                                                             │
│ INFO:root:{'Host': 'seldon-sd-ml-iris-accuracy-metrics-ml-multiclass.seldon.svc.cluster.local', 'User-Agent': 'Go-http-client/1.1', 'Content-Length': '77', 'Accept-Encoding': 'gzip', 'Ce-Endpoint': 'default', │
│ INFO:root:----                                                                                                                                                                                                   │
│ ERROR:root:[0], [1]                                                                                                                                                                                              │
│ INFO:root:binary CloudEvent                                                                                                                                                                                      │
│ INFO:root:ce-specversion: 1.0                                                                                                                                                                                    │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-id: dd4607a0-5e45-4095-a128-fc4042e481db                                                                                                                                                            │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-source: io.seldon.serving.ml-iris-accuracy-ml-multiclass                                                                                                                                            │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-type: io.seldon.serving.feedback.metrics                                                                                                                                                            │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-endpoint: default                                                                                                                                                                                   │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-inferenceservicename: ml-iris-accuracy                                                                                                                                                              │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-knativearrivaltime: 2024-02-20T14:24:46.696630186Z                                                                                                                                                  │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-modelid: ml-iris-accuracy-container                                                                                                                                                                 │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-namespace: seldon                                                                                                                                                                                   │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-protocol: seldon                                                                                                                                                                                    │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-requestid: cdd01f83-e402-4ba5-9a9c-f40e180d229a                                                                                                                                                     │
│                                                                                                                                                                                                                  │
│ INFO:root:ce-traceparent: 00-6c57b179c8b17780515515cdccc33e93-8b8c8dc339a1c913-00                                                                                                                                │
│                                                                                                                                                                                                                  │
│ INFO:root:b'{}'

Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majolo majolo merged commit a0c2ac4 into SeldonIO:master Feb 20, 2024
12 of 13 checks passed
@majolo majolo deleted the less-noisy-logging branch February 20, 2024 15:58
RafalSkolasinski pushed a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants