Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: support multi hosts in vs #5430

Merged
merged 10 commits into from
Apr 25, 2024
Merged

Feature: support multi hosts in vs #5430

merged 10 commits into from
Apr 25, 2024

Conversation

ooooona
Copy link
Contributor

@ooooona ooooona commented Mar 12, 2024 •
edited by RafalSkolasinski
Loading

Closes #5431

ooooona added 4 commits March 12, 2024 23:10
@ooooona
Update controller_utils.go
040311a 
add GetAnnotations() to support multi hosts
@ooooona
Update istio.go
1b5eb18 
add env ANNOTATION_ISTIO_HOST_SEPARATOR to support multi hosts
@ooooona
Update seldondeployment_controller.go
81b9151 
Update controller to support multi hosts
@ooooona
Update seldondeployment_explainers.go
9599dcd 
Update explianer to support multi hosts
@ooooona ooooona mentioned this pull request Mar 12, 2024
Closed
@RafalSkolasinski RafalSkolasinski self-assigned this Mar 18, 2024
ooooona added 4 commits March 21, 2024 21:14
@ooooona
Update istio.go
917831f 
Remove seperator defination
@ooooona
Update controller_utils.go
81d9699 
Rename GetAnnotation to HostsFromAnnotation, and remove the redundant logic
@ooooona
Update seldondeployment_explainers.go
48fec79
@ooooona
Update seldondeployment_controller.go
5699909
@CLAassistant
Copy link

CLAassistant commented Apr 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

RafalSkolasinski
RafalSkolasinski approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafalSkolasinski RafalSkolasinski merged commit c9ee03b into SeldonIO:master Apr 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalSkolasinski RafalSkolasinski RafalSkolasinski approved these changes

Assignees

@RafalSkolasinski RafalSkolasinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multi Hosts in seldon istio vs for Seldon V1
3 participants
@ooooona @CLAassistant @RafalSkolasinski