Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable tracing observability in docker-compose and helm chart #2137

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

VietND96
Copy link
Member

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

feat: enable tracing observability in docker-compose and helm chart

Motivation and Context

Instead of passing arguments for OpenTelemetry via ENV var JAVA_OPTS (or SE_JAVA_OPTS), it would be difficult to manage in case appending to an existing value. Create new ENV vars with prefix SE_OTEL_ for tracing configs

Before:
JAVA_OPTS="-Dotel.traces.exporter=jaeger -Dotel.exporter.jaeger.endpoint=http://jaegar:14250 -Dotel.resource.attributes=service.name=selenium-node-firefox"

After:
SE_OTEL_TRACES_EXPORTER (default is otlp) - pass value to -Dotel.traces.exporter=
SE_OTEL_EXPORTER_ENDPOINT=http://jaegar:4317 - pass value to -Dotel.exporter.${name}.endpoint=
In each component, by default, there is ENV SE_OTEL_SERVICE_NAME set its component name for argument -Dotel.resource.attributes=service.name=

Separate ENV vars for tracing configs also support better in helm chart template

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VietND96 VietND96 merged commit cd10250 into SeleniumHQ:trunk Feb 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant