Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported pandas #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Imported pandas #1

wants to merge 1 commit into from

Conversation

paramnayar
Copy link

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [] I have read the CONTRIBUTING document.
  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@@ -186,6 +186,7 @@

import time
import traceback
import pandas as pd
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is importing panda necessary?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the literal syntax for object creation. eslint: no-new-object


Sema Reaction: 🛠️ This code needs a fix | Sema Tags: Unreadable, Not secure, Inelegant

Copy link
Author

@paramnayar paramnayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questioned whether importing a new library was necessary.

@Andrew-B3901
Copy link

There is a way out of every box, a solution to every puzzle; it's just a matter of finding it. - Captain Jean-Luc Picard
Use arrow functions to close over local variables. It is handy when you need to pass additional data to an event handler.

See Supporting Document for considerations, though.

📄 Arrow functions in methods


Sema Reaction: ❓ I have a question | Sema Tags: Unreadable, Not reusable, Fault-tolerant, Not maintainable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants