Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .eslintrc.js #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mattvanitallie
Copy link

Summary: Summary of changes

Addresses CUMULUS-XX: Develop amazing new feature

Changes

  • Detailed list or prose of changes
  • ...

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@@ -1,4 +1,4 @@
'use strict';
# this is a test. 'use strict';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fix


Sema Reaction: 🛠️ This code needs a fix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t use iterators. Prefer JavaScript’s higher-order functions instead of loops like for-in or for-of. eslint: no-iterator no-restricted-syntax


Sema Reaction: ❓ I have a question | Sema Tags: Readable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tetstt a

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sd sd sa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need more repo
Make the code a little bit less clever in order to make it easier to read. Give it a stronger narrative structure so that you can more easily understand the code.

📄 Sema Community

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Unreadable, Secure, Reusable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test test fixgood
The purpose of having consensus and following it is to free up energy, not to consume it in favor of poorly-defined or subjective goals such as "it looks better". Having each one one make up his/her own rules "and damn the rest" is just as antisocial as forcing everyone to adhere to strict guidelines which dictate where you put your commas or spacing. Discipline provides freedom to the group, because once you achieve consensus on a matter, the effort of dealing with other's trespasses is greater than the effort of keeping oneself from trespassing.


Sema Reaction: 🛠️ This code needs a fix | Sema Tags: Unreadable, Secure, Inefficient, Not maintainable

Copy link

@artdimitrov artdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__
sema-logo  Summary: 👌 This code looks good

@ghost
Copy link

ghost commented Jan 20, 2022

Compute properties when possible

📄 Principles.dev

__
sema-logo  Summary: 🛠️ This code needs a fix

@ghost
Copy link

ghost commented Feb 2, 2022

The import . form can be useful in tests that, due to circular dependencies, cannot be made part of the package being tested

📄 Golang.org

__
sema-logo  Summary: 🛠️ This code needs a fix

@ghost
Copy link

ghost commented Mar 29, 2022

When concatenating multiple Strings, the “+” operator is inefficient because the Java compiler creates multiple intermediate String objects before creating the final concatenated string.

📄 Gitconnected

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Unreadable, Not secure

@Rusau
Copy link

Rusau commented Apr 4, 2022

test 4/4/2022

@ghost
Copy link

ghost commented Apr 6, 2022

comment to be edited
UPD

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Unreadable, Not secure, Inefficient

@ghost
Copy link

ghost commented Apr 6, 2022

comment to be edited UPD

__ sema-logo  🛠️ This code needs a fix  |  

reply testing__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Unreadable, Secure, Inefficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants