typechecker+codegen: Add index [] trait operator #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a workaround for a compiler bug, which has been fixed since.
alimpfard
force-pushed
the
tt
branch
2 times, most recently
from
3979f88
to
8c5bc14
Compare
This implements: - Index<Integral, T> for Array<T> - Index<Range<Integral>, ArraySlice<T>> for Array<T> - Index<Integral, T> for ArraySlice<T> - Index<Range<Integral>, ArraySlice<T>> for ArraySlice<T> - Index<K, V> for Dictionary<K, V> Co-Authored-By: 0GreenClover0 <[email protected]>
This rejects functions with the following criteria:
Any jakt-defined function which:
- Has a non-concrete argument type (trait name, or unknown) OR
- Has a non-concrete known return type.
This should only affect invalid programs.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are a mess; fixes for #1592. cc @0GreenClover0.