Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vim theme parser and right color scopes #5

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

Brayan-724
Copy link
Contributor

Vim theme

Vim theme has been parsed wrong, before this pr it was using bg as fg and vice versa, now it is correctly setted.
Before, when creating the theme is needed to have bg and fg in Normal highlight, but someone that doesn't want to set
it and just use the default colors (fg: #FFFFFF, bg: #000000) can't use this. Now, fg and bg fallbacks to the
default colors mentioned before.

Syntax scheme

There're a few colors that are linked wrong taking nvim from reference.

struct A;
// ^

This is highlighted with StorageClass. This means to a class (A), but it should be a Keyword.
There's repeated storage scope, is in StorageClass and Type, now it is only in Keyword

Copy link
Owner

@SergioRibera SergioRibera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SergioRibera SergioRibera merged commit fc8e92e into SergioRibera:main Mar 30, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants