Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build #258

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Improve build #258

merged 2 commits into from
Nov 9, 2023

Conversation

loevgaard
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9a9118d) 41.52% compared to head (8afcbf6) 41.44%.

❗ Current head 8afcbf6 differs from pull request most recent head 0ee0297. Consider uploading reports for the commit 0ee0297 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             0.12.x     #258      +/-   ##
============================================
- Coverage     41.52%   41.44%   -0.08%     
- Complexity      592      594       +2     
============================================
  Files           108      108              
  Lines          2105     2109       +4     
============================================
  Hits            874      874              
- Misses         1231     1235       +4     
Files Coverage Δ
...c/Api/CommandHandler/AddGiftCardToOrderHandler.php 100.00% <ø> (ø)
src/Api/CommandHandler/AddItemToCartHandler.php 100.00% <ø> (ø)
...Handler/AssociateConfigurationToChannelHandler.php 100.00% <ø> (ø)
...mandHandler/CreateGiftCardConfigurationHandler.php 77.77% <ø> (ø)
.../CommandHandler/RemoveGiftCardFromOrderHandler.php 100.00% <ø> (ø)
.../Action/UploadGiftCardConfigurationImageAction.php 96.42% <ø> (ø)
...tionExtension/GiftCardsByLoggedInUserExtension.php 100.00% <100.00%> (ø)
src/DependencyInjection/Configuration.php 100.00% <ø> (ø)
src/Validator/Constraints/DatePeriodValidator.php 92.30% <ø> (ø)
...DefaultGiftCardConfigurationMustExistValidator.php 0.00% <ø> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loevgaard loevgaard force-pushed the improve-build branch 28 times, most recently from a75e16f to 47cbd6d Compare November 8, 2023 15:14
@loevgaard loevgaard force-pushed the improve-build branch 2 times, most recently from c83c184 to a4e91d7 Compare November 8, 2023 15:21
@loevgaard loevgaard merged commit 044203e into 0.12.x Nov 9, 2023
66 checks passed
@loevgaard loevgaard deleted the improve-build branch November 9, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant