Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add periods on all sentences #80

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abcasada
Copy link

This addresses issue #49.

Adding periods at end of all sentences to address Shakil-Shahadat#49
Fix a few more periods that were missed in previous commit
@abcasada
Copy link
Author

abcasada commented Feb 4, 2024

@Shakil-Shahadat, are you ok with this one?

@Shakil-Shahadat
Copy link
Owner

There are several issues here,

  • Not all lines need a period at the end. For example, 'A Russian tracker' is not a complete sentence that needs a period at the end.
  • You have done more than adding periods
  • This PR has merge conflict
  • 1000+ changes in a single PR

Thousands of people are using this repository, one wrong move and people will stop using it. I need more time to review this, sorry. I appreciate your contribution, but please focus on fixing piracy-related links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants