Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes RSD route in ArticulateRouter #394

Merged
merged 5 commits into from
Jul 6, 2022
Merged

Fixes RSD route in ArticulateRouter #394

merged 5 commits into from
Jul 6, 2022

Conversation

warrenbuckley
Copy link
Contributor

Helps get one more thing done for getting this upto date for V5 #381

Copy link
Owner

@Shazwazza Shazwazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much time to test but I assume this follows the other routing patterns and it works?

src/Articulate/Routing/ArticulateRouter.cs Outdated Show resolved Hide resolved
@Shazwazza
Copy link
Owner

Once conflicts resolved i can merge

# Conflicts:
#	src/Articulate/Routing/ArticulateRouter.cs
@warrenbuckley
Copy link
Contributor Author

@Shazwazza Conflicts fixed
image

@Shazwazza Shazwazza merged commit ef94400 into Shazwazza:release/5.0.0 Jul 6, 2022
@warrenbuckley warrenbuckley deleted the routing/rsd branch July 7, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants