Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Add empower functions models and the supporting handler #630

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dyang415
Copy link

Thanks for the great benchmark @HuanzhiMao!

Create this PR to add the empower functions v1.1 model series models:

  • Register empower functions model series
  • Add empower_handler.py in support of running the newly added models
  • Update vllm to 0.5.5 in support of Llama 3.1 based models

Evaluation result:

Rank Overall Acc Model AST Summary Exec Summary Irrelevance Detection Relevance Detection
1 86.92% Empower-Fucntions-Large-v1.1 (FC) 82.55% 92.57% 78.51% 90.24%
2 83.89% Empower-Fucntions-Small-v1.1 (FC) 77.45% 89.43% 82.69% 85.37%

@dyang415
Copy link
Author

Hi @HuanzhiMao can you please take a look when you get a chance? Appreciate it!

@HuanzhiMao
Copy link
Collaborator

Apologize for the long delay. Will definitely take a look after the Monday ICLR deadline.

@dyang415
Copy link
Author

dyang415 commented Oct 2, 2024

Thanks @HuanzhiMao , rebased and updated to support BFCL v3.

Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dyang415,

Thanks for the PR.
Your model's chat template on huggingface (link) is the exact same as the one that meta-llama/Meta-Llama-3-70B-Instruct has (link). Therefore, the empower series model should just use the LlamaHandler (code link); there is no need for a separate handler.

@dyang415
Copy link
Author

dyang415 commented Oct 6, 2024

Hi @HuanzhiMao , though the chat template is the same, the way encoding function/response is very different compared with the llama function handler, so we still need the place to put the logic.

@HuanzhiMao
Copy link
Collaborator

empower functions v1.1 model series

Where can I find the mention of the encoding stuff in your huggingface or other documentation?

@dyang415
Copy link
Author

dyang415 commented Oct 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants