Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug where videos were not showing up on Safari #3562

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Fixed bug where videos were not showing up on Safari #3562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions assets/global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,12 @@ class DeferredMedia extends HTMLElement {
// force autoplay for safari
deferredElement.play();
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding a comment here like // Workaround for safari iframe bug, would prevent devs from thinking this is a useless block.

const formerStyle = deferredElement.getAttribute('style');
deferredElement.setAttribute('style', 'display: block;');
window.setTimeout(() => {
deferredElement.setAttribute('style', formerStyle);
}, 0);
}
}
}
Expand Down
Loading