Improve findAggregateContractMetric performance and introduce 30 second granularity for contract metrics
#1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
approved these changes
Feb 29, 2024
Co-authored-by: Peter-Jan Brone <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing some manual testing on Arequipa with about 34 million recorded contract metrics, I noticed that using multiple simpler queries (one select per contract per period) is a lot faster when combined with a composite index than a single more complex query.
This PR reduces the time it takes to display the contracts graph from about 25s down to <1s on the current set of data.
Combined with the granularity change of only recording one metric per contract every 5 minutes, a large host like Arequipa should only produce around 30 million rows a year.