Invalidate worker cache on ACL update #1605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndation/renterd into pj/invalidate-cache-on-acl-update
…date-cache-on-acl-update
peterjan
changed the title
|
Closing this due to #1639 which is a change of plans for our overall caching strategy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR invalidates the worker cache when we update the ACL on the bus. While writing a test I realised we currently don't take the ACL into account when downloading. I think this was by design, but I propose to change this and extend the contract filter modes with a new
downloadmode that only returns usable contracts.Related to #1587