Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated publishing #71

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kxmpxtxnt
Copy link

No description provided.

@kxmpxtxnt
Copy link
Author

kxmpxtxnt commented Dec 23, 2024

Todo:

  • Add tokens/secret via cli parameters from github secretes
  • Test it somehow (didnt get act) running to test it

- uses: actions/[email protected]
with:
distribution: "temurin"
java-version: "11"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also unsure about this part.
I have no idea if this works or if we need some other action

@kxmpxtxnt kxmpxtxnt marked this pull request as ready for review December 23, 2024 22:04
@kxmpxtxnt
Copy link
Author

More a general question but I think it wouldn't be bad if we had a second target for publishing besides maven central to release hotfixes or small insignificant updates.

@jakobkmar
Copy link
Member

More a general question but I think it wouldn't be bad if we had a second target for publishing besides maven central to release hotfixes or small insignificant updates.

You mean for snapshots? Hotfixes should also be deployed to maven central in my opinion.

But yes, maven central also provides a separate snapshot repo, which can be used for that.

@kxmpxtxnt
Copy link
Author

kxmpxtxnt commented Dec 24, 2024

More a general question but I think it wouldn't be bad if we had a second target for publishing besides maven central to release hotfixes or small insignificant updates.

You mean for snapshots? Hotfixes should also be deployed to maven central in my opinion.

But yes, maven central also provides a separate snapshot repo, which can be used for that.

Oh, I didn't know about the snapshot repo
Edit: Nvm, i did know about it, I was just dumb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants