Add comments and refactor style #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on tracking down a nasty synchronization bug I could keep all the data flows and puzzle pieces together in my mind, so I wrote some of them down as best as I was understanding them. Further I refactored some code because I find the terser styles afforded by ES2015+ syntax to confuse me less, especially when following around closures with `bind` and `call` and `apply`
dmsnell
commented
Feb 19, 2018
| @@ -47,6 +54,7 @@ internal.buildModifyChange = function( id, object, ghost ) { | |||
| } | |||
|
|
|||
| if ( empty ) return this.emit( 'unmodified', id, object, ghost ); | |||
| payload.v && payload.v.content && console.log(payload.v.content) | |||
There was a problem hiding this comment.
oops will take this out - part of my investigation
dmsnell
commented
Feb 19, 2018
| return update.call( bucket, id, object, options, function( err, object ) { | ||
| console.timeEnd('update') |
|
I've been exploring flowtype for this project and have cleaned up the Channel module quite a bit while experimenting. Take a look at #60 to see a much better documented and cleaner interface for |
|
Not enough time to rebase this and update it. It was a helpful exploration and hopefully it will happen again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on tracking down a nasty synchronization bug
I could keep all the data flows and puzzle pieces together
in my mind, so I wrote some of them down as best as I was
understanding them.
Further I refactored some code because I find the terser
styles afforded by ES2015+ syntax to confuse me less,
especially when following around closures with
bindandcallandapplyThe point isn't to change behaviors here but to figure them
out and write them down. That is, there should be no
functional changes in this patch and if there are then it's
probably a bug.