Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officalbags #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SomewhatSad14
Copy link

Description

-->

Media

Changelog

🆑 Generic

  • add: Added Centcom backpack
  • add: Added Centcom duffelbag

@github-actions github-actions bot added Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Needs Review Someone please review this labels Apr 11, 2023
@github-actions
Copy link

RSI Diff Bot; head commit c4c0740 merging into deaeb82
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Back/Backpacks/centcom.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Clothing/Back/Duffels/centcom.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

@DEATHB4DEFEAT
Copy link
Member

satchel?

Comment on lines +27 to +52
- type: entity
parent: Clothing
id: ClothingBackpackoffical
name: centcom backpack
description: An above average sized backpack, its lined with cloth, made for centcom officals.
components:
- type: Sprite
sprite: Clothing/Back/Backpacks/centcom.rsi
state: icon
- type: Item
size: 9999
- type: Clothing
quickEquip: false
slots:
- back
- type: Storage
capacity: 120
- type: ContainerContainer
containers:
storagebase: !type:Container
ents: []
- type: UserInterface
interfaces:
- key: enum.StorageUiKey.Key
type: StorageBoundUserInterface

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in a SimpleStation14 backpacks file, not Upstream.

Comment on lines +30 to +58
- type: entity
parent: Clothing
id: ClothingDuffelcentcom
name: centcom duffel bag
description: An above average sized duffel bag, its lined with cloth, made for centcom officals.
components:
- type: Sprite
sprite: Clothing/Back/Duffels/centcom.rsi
state: icon
- type: Item
size: 9999
- type: Clothing
quickEquip: false
slots:
- back
- type: Storage
capacity: 140
- type: ContainerContainer
containers:
storagebase: !type:Container
ents: []
- type: ClothingSpeedModifier
walkModifier: 1
sprintModifier: 0.8
- type: UserInterface
interfaces:
- key: enum.StorageUiKey.Key
type: StorageBoundUserInterface

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Comment on lines +3 to +4
"license": "CC-BY-SA-3.0",
"copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/547852588166c8e091b441e4e67169e156bb09c1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this accurate? Didn't you make these?

Comment on lines +3 to +4
"license": "CC-BY-SA-3.0",
"copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/547852588166c8e091b441e4e67169e156bb09c1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@DEATHB4DEFEAT DEATHB4DEFEAT added the Status: Awaiting Changes Do not merge due to requested changes label Apr 26, 2023
@Pspritechologist Pspritechologist removed the Status: Needs Review Someone please review this label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files Status: Awaiting Changes Do not merge due to requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants