Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial lib-bin split #132

Closed
wants to merge 0 commits into from
Closed

Conversation

pinkforest
Copy link
Contributor

@pinkforest pinkforest commented Jul 6, 2021

Addressing #124

Okay @Skallwar @CohenArthur this is pretty basic split but does the job as initial base layout.

Note the doc=false on bin is intentional for backwards cargo compatibility,

Otherwise we would need to have different library name to crate but newer cargo versions still do doc --bins despite this.

Copy link
Owner

@Skallwar Skallwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me for now. Looking forward to the next patch of this patch-set

@pinkforest pinkforest mentioned this pull request Jul 6, 2021
6 tasks
Copy link
Collaborator

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Cargo.toml Outdated Show resolved Hide resolved
@pinkforest
Copy link
Contributor Author

@Skallwar could you merge so I can rebase my branches, thx!

@Skallwar
Copy link
Owner

Skallwar commented Jul 7, 2021

Give me some time to create a release from what we have now

@Skallwar
Copy link
Owner

Skallwar commented Jul 7, 2021

We have some issue with the automatic build artifact upload, I will need to amend the release commit later today (I'm in class right now)

@pinkforest
Copy link
Contributor Author

pinkforest commented Jul 7, 2021

We have some issue with the automatic build artifact upload, I will need to amend the release commit later today (I'm in class right now)

Can you get rid of the .svg on that release, it freezes all firefox browsers for whoever is looking at the repo or crate page annoyingly :)

Or add the one I generated:
https://raw.githubusercontent.com/pinkforest/svg-testing-bloat/main/suckit-100cols-15rows.svg

Or I can send a separate PR for that

@Skallwar
Copy link
Owner

Skallwar commented Jul 7, 2021

A separate issue will be nice. I will make a PR to fix the CI anyway

@Skallwar
Copy link
Owner

Skallwar commented Jul 7, 2021

The release is out now. I had to force push because of the release ci only being triggered on release...

@Skallwar Skallwar reopened this Jul 7, 2021
@pinkforest pinkforest closed this Jul 7, 2021
@pinkforest pinkforest deleted the lib-bin branch July 7, 2021 17:58
@pinkforest
Copy link
Contributor Author

I'll re-create the branch.

@Skallwar
Copy link
Owner

Skallwar commented Jul 7, 2021

You could rebase on top of master? Do as you wish

@pinkforest
Copy link
Contributor Author

pinkforest commented Jul 7, 2021

I did :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants