-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial lib-bin split #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me for now. Looking forward to the next patch of this patch-set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Skallwar could you merge so I can rebase my branches, thx! |
Give me some time to create a release from what we have now |
We have some issue with the automatic build artifact upload, I will need to amend the release commit later today (I'm in class right now) |
Can you get rid of the .svg on that release, it freezes all firefox browsers for whoever is looking at the repo or crate page annoyingly :) Or add the one I generated: Or I can send a separate PR for that |
A separate issue will be nice. I will make a PR to fix the CI anyway |
The release is out now. I had to force push because of the release ci only being triggered on release... |
I'll re-create the branch. |
You could rebase on top of master? Do as you wish |
I did :) |
Addressing #124
Okay @Skallwar @CohenArthur this is pretty basic split but does the job as initial base layout.
Note the doc=false on bin is intentional for backwards cargo compatibility,
Otherwise we would need to have different library name to crate but newer cargo versions still do doc --bins despite this.