Feature/registry classes #6695
Merged
Feature/registry classes #6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
requested changes
May 15, 2024
src/main/java/ch/njol/skript/classes/registry/RegistryClassInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryUtils.java
Outdated
Show resolved
Hide resolved
Moderocky
approved these changes
May 21, 2024
APickledWalrus
requested changes
May 23, 2024
src/main/java/ch/njol/skript/classes/registry/RegistrySerializer.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryClassInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/registry/RegistryClassInfo.java
Outdated
Show resolved
Hide resolved
…er.java Co-authored-by: Patrick Miller <[email protected]>
…o.java Co-authored-by: Patrick Miller <[email protected]>
…o.java Co-authored-by: Patrick Miller <[email protected]>
sovdeeth
approved these changes
May 29, 2024
APickledWalrus
requested changes
Jun 6, 2024
APickledWalrus
approved these changes
Jun 7, 2024
yes, so for the time being please ignore my enchant PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to create a new set of classes based around the Bukkit Registry class.
The registry classes are based around EnumUtils, EnumClassInfo and EnumSerializer
Bukkit plans on using more registry things in the future.
As of right now the biome registry doesn't support custom biomes, but I believe the plan is to make that happen with 1.21
This allows Skript to get on board with registries and support stuff before we're forced to.
I believe Bukkit is also planning to drop enums for registry based classes, ie: Biomes, and switching to actual classes with static fields.
Another reason to prepare for the future.
Building off the same base of my Enchantments PR, a few things to note:
windswept hills) will be used as namemy_thing:hot_spicy_biome) will be used as nameI put this as a draft as I'm looking for feedback.
A lot was taken from the Enum classes for inspiration, but open to improvement.
I included registrant the Biome class info using this new method, to test/showcase how it works.
Target Minecraft Versions: any
Requirements: none
Related Issues: none