ExprBlocks - BlockLineIterator #7062
Open
+31
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed, fitInWorld function Fixed, Using vector function
|
you should add a regression test |
Efnilite
added
the
bug
TenFont
suggested changes
Sep 9, 2024
Efnilite
approved these changes
Sep 29, 2024
Found the problem, |
sovdeeth
requested changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the stack trace of using the
blocks between %loc% and %loc%if starting location is above max height limit.Starting off with my initial testing, the same stack trace occurred when below minimum height limit as well.
This issue was caused by the
fitInWorldfunction. As it was clamping the starting location to min/max height limit thus making theBlockIteratornot able to reach its goal.Personally, I see no point in using this function, as even though it would restrict the starting point to the limit, if you were to get 10 blocks above it, it would still go into the void.
Ultimately leading me to not use it anymore.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6437