Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EffSecShoot #7136

Open
wants to merge 21 commits into
base: dev/feature
Choose a base branch
from
Open

EffSecShoot #7136

wants to merge 21 commits into from
+353 −174

Conversation

TheAbsolutionism
Copy link

Description

This PR aims to convert EffShoot into an EffSecShoot, allowing users to manipulate all or any entities/projectiles and shooters instantaneously

Target Minecraft Versions: any
Requirements: none
Related Issues: #4789

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Oct 7, 2024
Efnilite
Efnilite requested changes Oct 7, 2024
View reviewed changes
src/main/java/ch/njol/skript/expressions/ExprShooter.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprShooter.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
sovdeeth
sovdeeth requested changes Oct 12, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
@TheAbsolutionism
Copy link
Author

Note:
For MC 1.19.4, to use launchProjectile with a consumer, requires the Bukkit Consumer type. Thus resulting the usage of Reflection in order to use the proper method.

sovdeeth
sovdeeth requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/sections/EffSecShoot.java Outdated Show resolved Hide resolved
sovdeeth
sovdeeth approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EffSecShoot#walk() still isn't my favorite, but as discussed on discord it's good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Efnilite Efnilite Efnilite approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Awaiting requested review from Moderocky

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheAbsolutionism @sovdeeth @Efnilite