Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expression conversion #7165

Open
wants to merge 9 commits into
base: dev/patch
Choose a base branch
from

Commits on Oct 27, 2024

  1. Configuration menu
    Copy the full SHA
    f0729a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    8595e2b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Configuration menu
    Copy the full SHA
    3115a89 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    983e864 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Add .sk to test file

    UnderscoreTud authored Nov 9, 2024
    Configuration menu
    Copy the full SHA
    e4ebe92 View commit details
    Browse the repository at this point in the history
  2. Simplify conversion usage

    We need to use conversion whenever there are multiple return types. If the expression does not accept our supertype, then we can attempt to convert it, which will already handle safety checks for multiple return types
    APickledWalrus committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    c6773ba View commit details
    Browse the repository at this point in the history
  3. SimpleExpression: fix possible return type conversion

    This fixes SimpleExpression not converting  possible return types that are not contained in the desired types array. For example, if an expression can return a Number or a String, and we want an Expression that is a Number or an World, it will now include converters for String->Number and String->World
    APickledWalrus committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    aad1339 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    bfe9b49 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Configuration menu
    Copy the full SHA
    5f70eb0 View commit details
    Browse the repository at this point in the history