-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expression conversion #7165
Open
UnderscoreTud
wants to merge
9
commits into
dev/patch
Choose a base branch
from
patch/expression-conversion
base: dev/patch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f0729a8 - Browse repository at this point
Copy the full SHA f0729a8View commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8595e2b - Browse repository at this point
Copy the full SHA 8595e2bView commit details
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3115a89 - Browse repository at this point
Copy the full SHA 3115a89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 983e864 - Browse repository at this point
Copy the full SHA 983e864View commit details
Commits on Nov 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e4ebe92 - Browse repository at this point
Copy the full SHA e4ebe92View commit details -
We need to use conversion whenever there are multiple return types. If the expression does not accept our supertype, then we can attempt to convert it, which will already handle safety checks for multiple return types
Configuration menu - View commit details
-
Copy full SHA for c6773ba - Browse repository at this point
Copy the full SHA c6773baView commit details -
SimpleExpression: fix possible return type conversion
This fixes SimpleExpression not converting possible return types that are not contained in the desired types array. For example, if an expression can return a Number or a String, and we want an Expression that is a Number or an World, it will now include converters for String->Number and String->World
Configuration menu - View commit details
-
Copy full SHA for aad1339 - Browse repository at this point
Copy the full SHA aad1339View commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bfe9b49 - Browse repository at this point
Copy the full SHA bfe9b49View commit details
Commits on Nov 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5f70eb0 - Browse repository at this point
Copy the full SHA 5f70eb0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.