Input API #7190
Open
Input API #7190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnderscoreTud
requested review from
sovdeeth,
Efnilite,
APickledWalrus and
Moderocky
Efnilite
requested changes
Nov 3, 2024
src/test/java/org/skriptlang/skript/test/tests/syntaxes/events/EvtPlayerInputTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/skriptlang/skript/test/tests/syntaxes/expressions/ExprCurrentInputKeysTest.java
Outdated
Show resolved
Hide resolved
Efnilite
approved these changes
Nov 3, 2024
|
i shed a tear when i saw the tests 🥹 |
i shed tears when i wrote the tests. for different reasons |
APickledWalrus
requested changes
Nov 5, 2024
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
| static { | ||
| if (Skript.classExists("org.bukkit.Input")) { | ||
| Skript.registerEvent("Player Input", EvtPlayerInput.class, PlayerInputEvent.class, | ||
| "[player] (toggle|toggling|1:press[ing]|2:releas(e|ing)) [of] (%-inputkeys%|[a|any] key)", |
There was a problem hiding this comment.
i don't like on toggle key as a syntax. also, any reason for separating toggle and toggling? i think it's clearer, but it's not consistent with the other two options (e.g. why not have release and releasing)
There was a problem hiding this comment.
i don't like
on toggle keyas a syntax.
on toggle key specifically or all its variations as well?
also, any reason for separating toggle and toggling? i think it's clearer, but it's not consistent with the other two options (e.g. why not have release and releasing)
I probably just missed by accident
src/test/java/org/skriptlang/skript/test/tests/syntaxes/conditions/CondIsPressingKeyTest.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Nov 8, 2024
src/main/java/org/skriptlang/skript/bukkit/input/elements/conditions/CondIsPressingKey.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/input/elements/events/EvtPlayerInput.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/input/elements/events/EvtPlayerInput.java
Outdated
Show resolved
Hide resolved
Moderocky
approved these changes
Nov 9, 2024
sovdeeth
approved these changes
Nov 9, 2024
sovdeeth
added
the
feature-ready
TheAbsolutionism
suggested changes
Nov 10, 2024
src/main/java/org/skriptlang/skript/bukkit/input/elements/expressions/ExprCurrentInputKeys.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/input/elements/expressions/ExprCurrentInputKeys.java
Show resolved
Hide resolved
Efnilite
reviewed
Nov 11, 2024
src/main/java/org/skriptlang/skript/bukkit/input/elements/conditions/CondIsPressingKey.java
Outdated
Show resolved
Hide resolved
TheAbsolutionism
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers all the features of the new Input API.
Target Minecraft Versions: 1.21.3
Requirements: none
Related Issues: none